chore: update OpenAPI spec, all clients, add rust to check workflow #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
sammccord
force-pushed
the
sammccord/update-all-clients
branch
from
8a08194 to
01c2971
Compare
sammccord
changed the title
sammccord
changed the title
0xRAG
approved these changes
Dec 10, 2025
marcin-cb
approved these changes
Dec 10, 2025
|
@sammccord can we publish the new rust sdk? |
juchiast
reviewed
Dec 11, 2025
| For EVM networks, the transaction will be a 0x-prefixed, EVM transaction hash. | ||
| For Solana-based networks, the transaction will be a base58-encoded Solana signature. | ||
| pattern: ^0x[a-fA-F0-9]{40}|[A-Za-z0-9][A-Za-z0-9-]{0,34}[A-Za-z0-9]$ | ||
| pattern: ^(0x[a-fA-F0-9]{40}|[1-9A-HJ-NP-Za-km-z]{32,44})$ |
There was a problem hiding this comment.
@sammccord This pattern is wrong, solana signature should be {64,88}
There was a problem hiding this comment.
@sammccord Also, I think EVM transaction hash is {64}, not {40}.
Contributor
Author
There was a problem hiding this comment.
💯 we're updating the spec and cutting a release asap today thanks for pointing this out
There was a problem hiding this comment.
@sammccord Thank you! There are some other issues here too #516 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update_openapiworkflowTests
Checklist
A couple of things to include in your PR for completeness: