Skip to content

Fix Record#setAudioOutput for non Audio only players #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Record#setAudioOutput for non Audio only players #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dfa5f9
Fix Record#setAudioOutput for non Audio only players
restless Sep 27, 2024
a403d63
Trigger Build
restless Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/videojs.record.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1897,7 +1897,7 @@ class Record extends Plugin {
break;

default:
let element = player.tech_.el_;
let element = this.player.tech_.el_;
if (deviceId) {
if (typeof element.sinkId !== 'undefined') {
element.setSinkId(deviceId).then((result) => {
Expand Down
21 changes: 21 additions & 0 deletions test/videojs.record.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,27 @@ describe('Record', () => {
});
});

/** @test {Record#setAudioOutput} */
it('can set audio output for video player', (done) => {
// create new audio-video player
let player = TestHelpers.makeAudioVideoPlayer();

player.one(Event.ERROR, (e) => {
expect(e.type).toEqual(Event.ERROR);

done();
});

player.one(Event.ENUMERATE_READY, () => {
player.record().setAudioOutput('fakeId');
});

player.one(Event.READY, () => {
player.record().enumerateDevices();
});
});


/** @test {Record#saveAs} */
it('saves as', (done) => {
// create new player
Expand Down