Skip to content

Conversation

@jms200
Copy link
Contributor

@jms200 jms200 commented Dec 11, 2025

  • Introduced variables for ClickHouse node group configuration, including name, instance types, size, and EBS volume settings.
  • Updated main.tf to include ClickHouse node group in the EKS module.
  • Modified variables.tf to add a toggle for enabling the ClickHouse node group and updated the description for additional node groups.

This enhancement allows for dedicated ClickHouse nodes in the EKS cluster, improving data processing capabilities.

- Introduced variables for ClickHouse node group configuration, including name, instance types, size, and EBS volume settings.
- Updated main.tf to include ClickHouse node group in the EKS module.
- Modified variables.tf to add a toggle for enabling the ClickHouse node group and updated the description for additional node groups.

This enhancement allows for dedicated ClickHouse nodes in the EKS cluster, improving data processing capabilities.
@jms200 jms200 requested a review from a team as a code owner December 11, 2025 15:11
@jms200 jms200 self-assigned this Dec 11, 2025
thalesac
thalesac previously approved these changes Dec 11, 2025
Copy link
Contributor

@thalesac thalesac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than instance type check with Liya - LGTM

CRThaze
CRThaze previously approved these changes Dec 12, 2025
@jms200 jms200 dismissed stale reviews from CRThaze and thalesac via d5747bb December 12, 2025 14:16
@jms200 jms200 requested review from CRThaze and thalesac December 12, 2025 14:17
Copy link
Contributor

@thalesac thalesac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - good job

@jms200 jms200 merged commit 37c2ca2 into main Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants