Skip to content

java codegen: expose the extension fields #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Jan 16, 2025

@mr-c mr-c marked this pull request as draft January 16, 2025 14:19
@mr-c mr-c force-pushed the java_extension_fields branch from 89353b9 to 8003f82 Compare January 16, 2025 16:03
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.31%. Comparing base (84139c7) to head (55e99c0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #908   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files          22       22           
  Lines        4952     4952           
  Branches     1185     1185           
=======================================
  Hits         4126     4126           
  Misses        548      548           
  Partials      278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mr-c mr-c force-pushed the java_extension_fields branch 2 times, most recently from 748354d to 8a666ce Compare January 29, 2025 13:22
@mr-c
Copy link
Member Author

mr-c commented Jan 29, 2025

@vedran-kasalica I fixed cwljava, and you can see the result of this change at common-workflow-language/cwljava#193 ; can you test it?

@vedran-kasalica
Copy link

@mr-c thank you for the update, I will work on the project and test it next week and let you know!

@mr-c
Copy link
Member Author

mr-c commented Apr 7, 2025

@vedran-kasalica how did the testing go?

@mr-c mr-c force-pushed the java_extension_fields branch from 8a666ce to da3fc7f Compare April 7, 2025 08:03
@mr-c mr-c force-pushed the java_extension_fields branch from da3fc7f to 55e99c0 Compare July 15, 2025 10:44
@mr-c mr-c marked this pull request as ready for review July 15, 2025 10:44
@mr-c mr-c enabled auto-merge (rebase) July 15, 2025 10:49
@mr-c mr-c merged commit 2012612 into main Jul 15, 2025
24 checks passed
@mr-c mr-c deleted the java_extension_fields branch July 15, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants