Skip to content

Conversation

Saifuddin53
Copy link
Contributor

Fixes: #6331

Updated the leaderboard spinner selection handler to accept nullable view references, preventing a crash when the spinner invokes the callback with a null view

@RitikaPahwa4444
Copy link
Collaborator

Thank you @Saifuddin53! Could you share steps to test these changes and possibly attach the screen recordings as well in the PR description (both before and after)?

Copy link

✅ Generated APK variants!

@rohit9625
Copy link
Collaborator

The changes in this PR that fix the NPE are already merged into the main branch, which is why the Files Changed tab looks empty.
For context, I originally made those changes while resolving this issue:

If we compare the crash logs from issue #6397 and issue #6331 (the one this PR is supposed to fix), they are identical. The only difference is in the reported scenario: in #6331, the crash occurs when opening the app after it has been idle, which likely means the activity was recreated (similar to what happens when changing the theme in settings).

Since I’ve already fixed that behavior in my earlier changes, this issue should no longer exist. That’s why I think we can safely close this PR.
What do you think, @RitikaPahwa4444?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE on opening the app again that was idle (in background)
3 participants