-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix #6409: Add listener call in ImageAdapter to update UI and upload #6420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolas-raoul
merged 5 commits into
commons-app:main
from
Kota-Jagadeesh:Fix/custom-selector-maximum-limit
Sep 15, 2025
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cd09c81
Fix #6409: Add listener call in ImageAdapter to update UI and upload …
Kota-Jagadeesh b2341c8
Merge branch 'main' into Fix/custom-selector-maximum-limit
nicolas-raoul 633210d
Fix image deselection issue in ImageAdapter to update UI correctly (#…
Kota-Jagadeesh a91d728
Merge branch 'main' into Fix/custom-selector-maximum-limit
nicolas-raoul a1d37e1
Prevent duplicate image selections on multiple taps in ImageAdapter w…
Kota-Jagadeesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes a lot of comments here and below, is that intended?
By the way it seems to be working, I will test more tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the confusion regarding the removed comments in the PR. The removal was unintentional and likely occurred during code cleanup to focus on the core fix for issue #6409. I’ve added the comments back to maintain clarity and documentation as per the original code. The changes still address the deselection issue by ensuring the UI updates correctly via the listener. Please let me know if there’s anything else I should adjust!