-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix/upload limit #3101 #6500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kota-Jagadeesh
wants to merge
9
commits into
commons-app:main
Choose a base branch
from
Kota-Jagadeesh:fix/upload-limit-#3101
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/upload limit #3101 #6500
Kota-Jagadeesh
wants to merge
9
commits into
commons-app:main
from
Kota-Jagadeesh:fix/upload-limit-#3101
+62
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated warning dialog strings, and ensured thumbnail bar consistency
nicolas-raoul
requested changes
Oct 14, 2025
app/src/main/java/fr/free/nrw/commons/customselector/ui/adapter/ImageAdapter.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@nicolas-raoul Changed from 5 image limit to 20 image limit as per #3101 (comment) |
nicolas-raoul
requested changes
Oct 14, 2025
app/src/main/java/fr/free/nrw/commons/customselector/ui/adapter/ImageAdapter.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@nicolas-raoul - Made the required changes. |
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3101
Implemented a strict 20-image selection and upload limit in the Wikimedia Commons app to prevent server overload and align with user feedback. Modified
CustomSelectorActivity.ktandImageAdapter.ktto restrict selection to 5 images, updatedUploadActivity.ktto process only 5 images, added a close button initem_custom_selector_image.xmlfor deselection, updatedcustom_selector_limit_dialog.xmlandstrings.xmlfor a clear 5-image limit message, and ensuredThumbnailsAdapter.ktdisplays only 5 images in the upload UI thumbnail bar.