Syncup wlav #155
Open
Syncup wlav #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ena volatility, e.g. by the default compiler) from wlav@777f55e
Comment on lines
+1355
to
+1366
| def test45_typedef_resolution(self): | ||
| """Typedefs starting with 'c'""" | ||
|
|
||
| import cppyy | ||
|
|
||
| cppyy.cppdef("""\ | ||
| typedef const int my_custom_type_t; | ||
| typedef const int cmy_custom_type_t; | ||
| """) | ||
|
|
||
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("my_custom_type_t") == "const int" | ||
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("cmy_custom_type_t") == "const int" |
There was a problem hiding this comment.
This test does not make sense with our fork.
There was a problem hiding this comment.
We need to rework it and fix it upstream, too...
Comment on lines
+1722
to
+1723
| if cppyy.gbl.gInterpreter.ProcessLine("__cplusplus;") <= 201402: | ||
| # string_view exists as of C++17 |
There was a problem hiding this comment.
Suggested change
| if cppyy.gbl.gInterpreter.ProcessLine("__cplusplus;") <= 201402: | |
| # string_view exists as of C++17 | |
| if cppyy.gbl.Cpp.Evaluate("__cplusplus") <= 201402: | |
| # string_view exists as of C++17 |
| import cppyy | ||
|
|
||
| cppyy.cppdef("""\ | ||
| #if __has_include(<span>) |
There was a problem hiding this comment.
Suggested change
| #if __has_include(<span>) | |
| #if __cplusplus >= 202002 |
There was a problem hiding this comment.
Why do we need this instead of the has_include?
There was a problem hiding this comment.
Look at https://godbolt.org/z/6E8v4vooo with and without the -std=c++20.
There was a problem hiding this comment.
Good catch. Can you make sure this is updated upstream too?
Comment on lines
+1360
to
+1366
| cppyy.cppdef("""\ | ||
| typedef const int my_custom_type_t; | ||
| typedef const int cmy_custom_type_t; | ||
| """) | ||
|
|
||
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("my_custom_type_t") == "const int" | ||
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("cmy_custom_type_t") == "const int" |
There was a problem hiding this comment.
Suggested change
| cppyy.cppdef("""\ | |
| typedef const int my_custom_type_t; | |
| typedef const int cmy_custom_type_t; | |
| """) | |
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("my_custom_type_t") == "const int" | |
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("cmy_custom_type_t") == "const int" | |
| cppyy.cppdef("""\ | |
| namespace Cppyy { | |
| std::string ResolveName(const std::string& name); | |
| } | |
| typedef const int my_custom_type_t; | |
| typedef const int cmy_custom_type_t; | |
| """) | |
| assert cppyy.gbl.Cppyy.ResolveName("my_custom_type_t") == "const int" | |
| assert cppyy.gbl.Cppyy.ResolveName("cmy_custom_type_t") == "const int" |
|
Hi @aaronj0, I guess you forgot to sync the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings our cppyy frontend up to date with wlav/cppyy:
Introduces all new tests (up to 540)
Adds new functions to the frontend (macro, as_memoryview)
Updates dictionaries for the same
Requires updating test tags based on CI results