-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: District landing page #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
as part of the district landing page feature, we set the default station to None to show a summary for all stations in the district. this requires not displaying the lane selector until a station is selected.
reorganize map components to accomodate a new district summary view
pages in the Django app are set to use a full width layout. the height of the div containing the streamlit app is also set to full height. the streamlit app (page) is configured to use a wide layout.
1b477d6
to
8bdd12b
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
The District-level metadata is a great addition, meaning the user sees something right away when they land on a district page 👍

I was seeing a little strangeness when going from District > Station > back to District (e.g. deselecting all Stations). The "ghost" info was still visible from the prior station selection:

Not sure if there is a way to avoid that with placeholders or otherwise?
if a station is selected and then de-selected, some information associated with the station is not cleared, i.e., Absolute Post Mile and Lanes stay greyed out, Streamlit's sign of "stale data". it turns out that the st.empty() method sometimes needs some time to take effect on the front-end. adding a small delay ensures that the DOM is ready for st.empty().
Thanks for catching that @thekaveman! This behavior is strange because we are using the same strategy as |
Closes #205, closes #202
This PR updates the District landing page, e.g.
/districts/7
, and uses a full-width (and height) design for the 5-min data visualization. It uses the method laid out in the full-width design spike (using thecontainer-fluid
class) and sets the Streamlit page configuration to awide
layout.