GHA: wire up swift-tools-protocols #1049
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the new swift-tools-protocols dependency into the Swift toolchain build workflow. The dependency abstracts tooling protocols (BSP, LSP, etc.) and is being added proactively before it becomes a critical requirement.
Key Changes:
- Added
swift-tools-protocolsas a required input parameter with version 0.0.2 - Integrated checkout, configuration, build, and installation steps for the new dependency
- Wired up the dependency for both
swift-buildandswift-package-managercomponents
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/swift-toolchain.yml | Added checkout, build, configure, and install steps for swift-tools-protocols; configured swift-build and swift-package-manager to depend on it |
| .github/workflows/build-toolchain.yml | Added swift_tools_protocols_revision parameter with default version 0.0.2 and propagated it through the workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This new dependency abstracts out the tooling protocol (i.e. BSP, LSP, etc). Add the build before we must scramble.
compnerd
force-pushed
the
compnerd/protocol
branch
from
7ee2cde to
073bbfc
Compare
|
Pretty sure that this is ready: downstream run at https://github.com/thebrowsercompany/swift-build/actions/runs/18978169335. We need to bump the swift-tools-protocols pin to 0.0.8, but will wait to follow upstream on this. |
Co-authored-by: Copilot <[email protected]>
|
Upstream merged this work, going to merge this in the hopes of getting ahead of this. |
This new dependency abstracts out the tooling protocol (i.e. BSP, LSP, etc). Add the build before we must scramble.