Re-enable vendoring #410
Merged
Re-enable vendoring #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an example of Renovate PR opened in my fork with this PR applied: jankaluza#2 |
|
Second commit skips the codespell for the |
Luap99
requested changes
Oct 22, 2025
github-actions
bot
added
storage
|
@Luap99 , done in the third commit. I also renamed the tidy-in-container to vendor-in-container, but I did not find any place where this is executed - probably only manually? |
Luap99
approved these changes
Oct 22, 2025
mtrmac
reviewed
Oct 22, 2025
There was a problem hiding this comment.
Thanks, makes sense overall.
(For the record, AFAICT we need the vendor step because Renovate only does go work sync if vendoring is enabled, per #291 (comment) .)
The Renovate PR to support top-level vendor directory is merged and should be deployed in the production. It should be safe to re-enable the vendoring now. Signed-off-by: Jan Kaluza <[email protected]>
We do not want to check the spelling in the code we do not own. Signed-off-by: Jan Kaluza <[email protected]>
And also run the `go work sync` in the end of the main Makefile. Signed-off-by: Jan Kaluza <[email protected]>
jankaluza
force-pushed
the
vendor-2
branch
2 times, most recently
from
83aaec1 to
af0fbec
Compare
Signed-off-by: Jan Kaluza <[email protected]>
Signed-off-by: Jan Kaluza <[email protected]>
|
I also had to disable the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Renovate PR to support top-level vendor directory is merged and should be deployed in the production.
It should be safe to re-enable the vendoring now.