Skip to content

feat(libartifact): Modify NewArtifactStore signature for artifact events #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(libartifact): Modify NewArtifactStore signature for artifact events #418

wants to merge 2 commits into from

Conversation

@nimdrak
Copy link

@nimdrak nimdrak commented Oct 25, 2025 •
edited
Loading

This commit introduces a new paremeter in NewArtifactStore, to allow external consumers to register a callback function for artifact-related events.

The following methods now invoke the event callback if one is provided:

  • Remove
  • Pull
  • Push
  • Add
  • Extract
  • ExtractTarStream

Fixes #27260 containers/podman#27324

@github-actions github-actions bot added the common Related to "common" package label Oct 25, 2025
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 25, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#418
fd229e3
@podmanbot
Copy link

✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6451

@podmanbot podmanbot mentioned this pull request Oct 25, 2025
Draft
@nimdrak nimdrak changed the title Fixed #27260 Add NewArtifactStoreWithEventCallback for events of artifact feat(libartifact): Add NewArtifactStoreWithEventCallback for artifact events Oct 26, 2025
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 26, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#418
4072c20
@nimdrak nimdrak mentioned this pull request Oct 27, 2025
Open
@nimdrak nimdrak marked this pull request as ready for review October 27, 2025 03:46
mtrmac
mtrmac reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick skim, looking at the API. I didn’t actually review the implementation much at all.

Cc: @baude .

podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Oct 28, 2025
@github-actions
dnm: Vendor changes from containers/container-libs#418
0f23599
@nimdrak nimdrak changed the title feat(libartifact): Add NewArtifactStoreWithEventCallback for artifact events feat(libartifact): Modify NewArtifactStore signature for artifact events Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrmac mtrmac mtrmac left review comments

Assignees

No one assigned

Labels

common Related to "common" package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nimdrak @podmanbot @mtrmac