feat(toolsets): add support for multiple toolsets in configuration #323
Conversation
manusa
force-pushed
the
feat/toolsets
branch
from
1844da7 to
8d49abf
Compare
manusa
force-pushed
the
feat/toolsets
branch
2 times, most recently
from
ba40e69 to
5bfba5f
Compare
Users can now enable or disable different toolsets either by providing a command-line flag or by setting the toolsets array field in the TOML configuration. Downstream Kubernetes API developers can declare toolsets for their APIs by creating a new nested package in pkg/toolsets and registering it in pkg/mcp/modules.go Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
feat/toolsets
branch
from
5bfba5f to
115c43d
Compare
| func Default() *StaticConfig { | ||
| return &StaticConfig{ | ||
| ListOutput: "table", | ||
| Toolsets: []string{"core", "config", "helm"}, |
There was a problem hiding this comment.
I would leave helm out of the default set.
There was a problem hiding this comment.
In <= v0.0.50 it's included by default.
I would do that after the first release with the toolsets feature so that we don't make it a breaking change.
We can also make it more palatable for upstream users if we remove it from the default set of toolsets but in exchange we add a few more features (e.g. helm toolset is no longer activated by default since it now includes multiple tooling specific to helm, you can enable it by starting the kubernetes MCP server with the following flag --toolsets core,config,helm).
IMO, the plan should be release v0.0.51 with toolsets without the breaking changes, then, release v0.0.52 with deactivated and specialized toolsets such as helm.
Similarly, for the config one, we could enable it only in stdio mode which is the only deployment+runtime mode where it makes sense.
|
This looks good to me. |
Fixes #227
Fixes #115
Users can now enable or disable different toolsets either by providing a command-line flag or by setting the toolsets array field in the TOML configuration.
Downstream Kubernetes API developers can declare toolsets for their APIs by creating a new nested package in pkg/toolsets and registering it in pkg/mcp/modules.go
/cc @mrunalp @ardaguclu