Skip to content

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jul 30, 2025

Some new crates we have to use but not actually code changes.

Summary by Sourcery

Upgrade gRPC and protobuf dependencies to the 0.14 series and adapt the build pipeline to use the new tonic-prost build tools.

Enhancements:

  • Bump tonic to 0.14.0 and prost to 0.14.1 and introduce tonic-prost 0.14.0

Build:

  • Replace tonic-build with tonic-prost-build in Cargo.toml
  • Update build.rs to configure protobuf generation with tonic_prost_build

Some new crates we have to use but not actually code changes.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link

sourcery-ai bot commented Jul 30, 2025

Reviewer's Guide

This PR upgrades the gRPC and protobuf toolchain to tonic/prost v0.14 by bumping crate versions, replacing the build integration crate with tonic-prost-build, adjusting the build script invocation, and regenerating the lock file.

Class diagram for build script integration update

classDiagram
    class build_rs {
        +main()
    }
    class tonic_build {
        +configure()
    }
    class tonic_prost_build {
        +configure()
    }
    build_rs ..> tonic_build : (before)
    build_rs ..> tonic_prost_build : (after)
Loading

File-Level Changes

Change Details Files
Upgrade core gRPC/protobuf dependencies to v0.14
  • Bump tonic to 0.14.0
  • Add tonic-prost v0.14.0
  • Update prost to 0.14.1
Cargo.toml
Switch build integration to tonic-prost-build
  • Replace tonic-build with tonic-prost-build in build-dependencies
  • Update build.rs to call tonic_prost_build::configure instead of tonic_build
Cargo.toml
build.rs
Regenerate Cargo.lock
  • Update lock file to reflect new dependency versions
Cargo.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Luap99 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Jul 30, 2025

LGTM

@mheon
Copy link
Member

mheon commented Jul 30, 2025

Needs MSRV bump, though. Can we do that, given how new 1.86 is?

@Luap99
Copy link
Member Author

Luap99 commented Jul 30, 2025

Needs MSRV bump, though. Can we do that, given how new 1.86 is?

Fedora and RHEL should already have newer versions AFAIK but there is no reason that this must be included in this release so I am fine to leave this open and merge it after we make the release then we have ~3 months extra time for it to sit and distros to upgrade.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants