-
Notifications
You must be signed in to change notification settings - Fork 114
update tonic and prost to 0.14 #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Some new crates we have to use but not actually code changes. Signed-off-by: Paul Holzinger <[email protected]>
Reviewer's GuideThis PR upgrades the gRPC and protobuf toolchain to tonic/prost v0.14 by bumping crate versions, replacing the build integration crate with tonic-prost-build, adjusting the build script invocation, and regenerating the lock file. Class diagram for build script integration updateclassDiagram
class build_rs {
+main()
}
class tonic_build {
+configure()
}
class tonic_prost_build {
+configure()
}
build_rs ..> tonic_build : (before)
build_rs ..> tonic_prost_build : (after)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, sourcery-ai[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
Needs MSRV bump, though. Can we do that, given how new 1.86 is? |
Fedora and RHEL should already have newer versions AFAIK but there is no reason that this must be included in this release so I am fine to leave this open and merge it after we make the release then we have ~3 months extra time for it to sit and distros to upgrade. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Some new crates we have to use but not actually code changes.
Summary by Sourcery
Upgrade gRPC and protobuf dependencies to the 0.14 series and adapt the build pipeline to use the new tonic-prost build tools.
Enhancements:
Build: