Skip to content

ignore Read-only file system error on sysctl set #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ignore Read-only file system error on sysctl set #910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/network/core_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,18 @@ impl CoreUtils {
}
Err(e) => return Err(e),
}
ctl.set_value_string(val)
let result = ctl.set_value_string(val);
// if we have a read only /proc we ignore it as well
match result {
Ok(_) => result,
Err(SysctlError::IoError(e)) => {
if e.raw_os_error() == Some(libc::EROFS) {
return Ok(String::from(""));
}
return Err(e.into());
},
Err(err) => return Err(err),
}
}
}

Expand Down Expand Up @@ -433,9 +444,6 @@ pub fn disable_ipv6_autoconf(if_name: &str) -> NetavarkResult<()> {
// just ignore that case
}

// if we have a read only /proc we ignore it as well
SysctlError::IoError(ref e) if e.raw_os_error() == Some(libc::EROFS) => {}

_ => {
return Err(NetavarkError::wrap(
"failed to set autoconf sysctl",
Expand Down