feat(podman-logs): improve logs formatting and behavior like docker-c… #1269
+165
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
reviewed
Jul 12, 2025
| await asyncio.gather(*tasks, return_exceptions=True) | ||
| raise | ||
| else: | ||
| podman_args = [] |
There was a problem hiding this comment.
Seems like duplicate code now.
p12tic
reviewed
Jul 12, 2025
| service_name = cnt["_service"] | ||
| container_name = cnt["name"] | ||
|
|
||
| if getattr(args, 'names', False): |
p12tic
reviewed
Jul 12, 2025
| display_name = container_name | ||
|
|
||
| space_suffix = " " * (max_service_length + 1 - len(display_name)) | ||
| log_formatter = "{}{}{}|\x1b[0m".format(color, display_name, space_suffix) |
There was a problem hiding this comment.
Duplicate code, including space_suffix.
p12tic
reviewed
Jul 12, 2025
| podman_args.append(target) | ||
|
|
||
| task = asyncio.create_task( | ||
| compose.podman.run([], "logs", podman_args, log_formatter=log_formatter), |
There was a problem hiding this comment.
Future improvement (not this PR): run only single podman logs command and improve the formatter to be able to apply different formatting depending on container ID that podman logs emits on every line.
|
Thanks for the pull request, the basic idea looks great, I just had several nits regarding code style. Could you please also add a newsfragment and an integration test? |
arkhan
force-pushed
the
feat/improve-logs-handling
branch
from
3a39657 to
f76bda4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the logging output for containers, making it more
consistent with docker-compose behavior.
By default, the logs now include the project name along with the service name,
making it easier to identify containers in multi-service setups. If the
-nor--nameflag is provided, the project name is omitted from the logs prefix.Additionally, if a
container_nameis explicitly defined in the configuration,it will always be shown by default instead of the generated name.
This enhancement helps users track logs more easily when managing multiple
containers.
BREAKING CHANGE: Logs output format may differ from previous versions.