Fix service_completed_successfully to require exit code 0 #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrIncompetent
force-pushed
the
depends_on_exit_code
branch
2 times, most recently
from
c77e027 to
5119348
Compare
Previously accepted any container stop, now correctly validates exit code 0 matching Docker Compose behavior. Docker Compose implementation reference: https://github.com/docker/compose/blob/v2.29.7/pkg/compose/convergence.go#L433 Signed-off-by: Henrik Schmidt <[email protected]>
mrIncompetent
force-pushed
the
depends_on_exit_code
branch
from
5119348 to
3e4ef09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously accepted any container stop, now correctly validates exit code 0 matching Docker Compose behavior.
Docker Compose implementation reference:
https://github.com/docker/compose/blob/v2.29.7/pkg/compose/convergence.go#L433