-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add BuildArg key to quadlets #27256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add BuildArg key to quadlets #27256
Conversation
Signed-off-by: givensuman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
In addition, the new key should be documented in docs/source/markdown/podman-systemd.unit.5.md
Signed-off-by: givensuman <[email protected]>
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Signed-off-by: givensuman <[email protected]>
our linters found some issues as well which is why CI failed. assuming you have podman installed in $PATH, a |
Co-authored-by: Tom Sweeney <[email protected]> Signed-off-by: givensuman <[email protected]>
Signed-off-by: givensuman <[email protected]>
159751e
to
b4d81c0
Compare
LGTM, @ygalblum if you are happy with this, can you also give a LGTM? |
Cockpit tests failed for commit b4d81c0. @martinpitt, @jelly, @mvollmer please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@baude I'm not officially approving the PR, because @TomSweeneyRedHat has an unresolved comment
Signed-off-by: givensuman <[email protected]>
04cec8e
to
1e713c1
Compare
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Both test failures look like flakes. Restarted. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: givensuman, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@TomSweeneyRedHat do we have your thumbs up for the doc fixes? |
This addresses #27065, adding a
BuildArg
key to quadlet.build
files. I believe I correctly integrated this into existing tests with this file.Does this PR introduce a user-facing change?