Skip to content

Conversation

givensuman
Copy link

This addresses #27065, adding a BuildArg key to quadlet .build files. I believe I correctly integrated this into existing tests with this file.

Does this PR introduce a user-facing change?

Add BuildArg key to quadlet `.build` files which equates to `podman build --build-arg` flag.

Signed-off-by: givensuman <[email protected]>
Copy link
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
In addition, the new key should be documented in docs/source/markdown/podman-systemd.unit.5.md

Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@baude
Copy link
Member

baude commented Oct 8, 2025

our linters found some issues as well which is why CI failed. assuming you have podman installed in $PATH, a make validatepr should run them for you before you check things in.

givensuman and others added 2 commits October 9, 2025 09:44
Co-authored-by: Tom Sweeney <[email protected]>
Signed-off-by: givensuman <[email protected]>
Signed-off-by: givensuman <[email protected]>
@givensuman givensuman force-pushed the T-27065-add-quadlet-build-args-support branch from 159751e to b4d81c0 Compare October 9, 2025 13:45
@baude
Copy link
Member

baude commented Oct 9, 2025

LGTM, @ygalblum if you are happy with this, can you also give a LGTM?

Copy link

Cockpit tests failed for commit b4d81c0. @martinpitt, @jelly, @mvollmer please check.

Copy link
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@baude I'm not officially approving the PR, because @TomSweeneyRedHat has an unresolved comment

@givensuman givensuman force-pushed the T-27065-add-quadlet-build-args-support branch from 04cec8e to 1e713c1 Compare October 10, 2025 17:25
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@givensuman givensuman requested a review from ygalblum October 11, 2025 18:24
@mheon
Copy link
Member

mheon commented Oct 13, 2025

Both test failures look like flakes. Restarted.

@mheon
Copy link
Member

mheon commented Oct 13, 2025

/approve
LGTM

Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: givensuman, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@ygalblum
Copy link
Contributor

@TomSweeneyRedHat do we have your thumbs up for the doc fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants