Skip to content

Fix flaky sysctl completion by handling /proc/sys errors gracefully #27262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
+7 −3
Merged

Fix flaky sysctl completion by handling /proc/sys errors gracefully #27262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cmd/podman/common/completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1979,12 +1979,16 @@ func AutocompleteSysctl(_ *cobra.Command, _ []string, toComplete string) ([]stri
var completions []string
sysPath := "/proc/sys"

err := filepath.Walk(sysPath, func(path string, info os.FileInfo, err error) error {
err := filepath.WalkDir(sysPath, func(path string, d fs.DirEntry, err error) error {
if err != nil {
return err
// /proc/sys is a volatile virtual filesystem whose contents change dynamically.
// Skip directories on any error (race conditions, permission denied, etc.) to
// provide partial completion results rather than failing completely.
// See: https://github.com/containers/podman/issues/27252
return filepath.SkipDir
}

if !info.IsDir() {
if !d.IsDir() {
rel, err := filepath.Rel(sysPath, path)
if err != nil {
return err
Expand Down