Feature/cmg 686 #802
Open
Feature/cmg 686 #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new build.sh script for region selection and OAuth login. - Added app.json to .gitignore and included manifest.json in API .gitignore. - Updated package dependencies for improved functionality. - Implemented saveOAuthToken endpoint for secure token handling. - Enhanced region configuration and API host management in constants. - Added error handling and logging improvements in auth service.
…cies - Removed redundant variables for client_id and client_secret in saveOAuthToken function. - Updated logging to use a centralized logger instead of console methods. - Removed unnecessary deletion of code_verifier from the request session. - Updated package.json to remove outdated "api" dependency.
- Modified build.sh to append '/v2/auth/save-token' to the redirect_uri. - Updated auth.service.ts to use the correct redirect_uri for token requests. - Ensured consistency in region configuration and API endpoint handling.
- Added new endpoints for retrieving app configuration and checking SSO authentication status. - Updated authentication service to handle SSO tokens and access tokens more effectively. - Enhanced error handling for SSO-related operations. - Updated UI components to support SSO login and added corresponding styles. - Refactored API service calls to accommodate new SSO logic and improved token management.
umeshmore45
requested review from
Copilot,
sauravraw,
sayalijoshi27 and
umeshmore45
There was a problem hiding this comment.
Pull Request Overview
This PR implements Single Sign-On (SSO) authentication support for the migration tool. The changes add OAuth-based authentication alongside existing basic authentication, enabling users to log in via SSO through Contentstack's OAuth flow.
- Adds SSO login functionality with OAuth token handling
- Updates authentication services to support both basic auth and OAuth tokens
- Implements SSO configuration and status checking endpoints
Reviewed Changes
Copilot reviewed 26 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/src/config/index.ts | Updates default values for CMS type and local path configuration |
| ui/src/services/api/login.service.ts | Adds SSO-related API service functions for app config and auth status |
| ui/src/pages/Login/index.tsx | Implements SSO login UI with polling mechanism and auth handling |
| ui/src/pages/Login/index.scss | Adds CSS styles for SSO button and related UI elements |
| build.sh | Adds build script for region selection and OAuth setup |
| api/sso.utils.js | Migration utility for SSO setup and OAuth configuration |
| api/src/utils/config-handler.util.ts | Utility functions for OAuth and basic auth configuration |
| api/src/utils/auth.utils.ts | Adds access token retrieval function for OAuth |
| Multiple API services | Updates authentication handling to support both OAuth and basic auth tokens |
| api/src/services/auth.service.ts | Core OAuth implementation with token exchange and refresh |
| api/src/routes/auth.routes.ts | Adds SSO-related API endpoints |
| api/src/models/types.ts | Extends types to support SSO authentication |
| api/src/controllers/auth.controller.ts | Implements SSO controller methods |
| api/src/constants/index.ts | Adds regional authentication endpoints |
| api/package.json | Updates dependencies and removes module type |
Files not reviewed (1)
- api/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sayalijoshi27
requested changes
Sep 30, 2025
An error occurred while trying to automatically change base from
dev
to
pre-stage
October 8, 2025 13:04
An error occurred while trying to automatically change base from
dev
to
pre-stage
October 9, 2025 12:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.