feat: run dependent indexer based on context provider #6323
+56
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
👷 Deploy request for continuedev pending review.Visit the deploys page to approve it
|
uinstinct
changed the title
sestinj
requested changes
Jun 30, 2025
| @@ -19,7 +19,7 @@ class FolderContextProvider extends BaseContextProvider { | |||
| displayTitle: "Folder", | |||
| description: "Type to search", | |||
| type: "submenu", | |||
| dependsOnIndexing: true, | |||
| indexTypes: ["embeddings"], | |||
There was a problem hiding this comment.
This should rely on the same list as @ codebase (embeddings, fullTextSearch, chunk)
core/protocol/webview.ts
Outdated
| @@ -24,7 +24,7 @@ export type ToWebviewFromIdeOrCoreProtocol = { | |||
| "indexing/statusUpdate": [IndexingStatus, void]; // Docs, etc. | |||
| refreshSubmenuItems: [ | |||
| { | |||
| providers: "all" | "dependsOnIndexing" | ContextProviderName[]; | |||
| providers: "all" | "indexTypes" | ContextProviderName[]; | |||
There was a problem hiding this comment.
I feel like we could keep this as "dependsOnIndexing". That seems like a variable name that makes more sense, and I don't think the behavior changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We do not need to run all the indexes if only a set of selected context providers are enabled in our config. This PR adds the ability to run only dependent indexers determined by
indexTypesproperty on the context provider.dependsOnIndexingkey value withindexTypesResolves CON-2399
Checklist
Screenshots
[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Reproduction
I used a debug statement like this
console.log("indexTypesToBuild", [...indexTypesToBuild],"and config",config,);insideCodebaseIndexer.tsto check if dependent indexing steps are presentSummary by cubic
Updated context providers to specify which indexers they need, so only the required indexers run based on the config.
dependsOnIndexingflag with a newindexTypesproperty.