feat: generate rule dialog #6421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Erichsen
requested review from
tomasz-stefaniak
and removed request for
a team
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:XXL
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 7 issues across 19 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
Patrick-Erichsen
force-pushed
the
pe/rule-dialog
branch
from
3c7cc87 to
e2a7d47
Compare
RomneyDa
reviewed
Jul 2, 2025
There was a problem hiding this comment.
- alwaysApply could be confusing for the model (didn't we remove before because of this?). Instead, we could map the user-friendly names like agent requested to the tool args somehow
- Button borders have looked a bit clanky, should we fix since this form has many?
- the new llmStreamChat with tools adds surface area in a way that might be hard to work with in the future, e.g. won't work with virtual tools. We should combine into util
RomneyDa
reviewed
Jul 2, 2025
RomneyDa
approved these changes
Jul 3, 2025
| @@ -13,7 +13,7 @@ export const createRuleBlock: Tool = { | |||
| function: { | |||
| name: BuiltInToolNames.CreateRuleBlock, | |||
| description: | |||
| 'Creates a "rule" that can be referenced in future conversations. This should be used whenever you want to establish code standards / preferences that should be applied consistently, or when you want to avoid making a mistake again. To modify existing rules, use the edit tool instead.', | |||
| 'Creates a "rule" that can be referenced in future conversations. This should be used whenever you want to establish code standards / preferences that should be applied consistently, or when you want to avoid making a mistake again. To modify existing rules, use the edit tool instead.\n\nRule Types:\n- Always: Include only "rule" (always included in model context)\n- Auto Attached: Include "rule", "globs", and/or "regex" (included when files match patterns)\n- Agent Requested: Include "rule" and "description" (AI decides when to apply based on description)\n- Manual: Include only "rule" (only included when explicitly mentioned using @ruleName)', | |||
There was a problem hiding this comment.
change alwaysApply to a more readable "rule_type" arg
There was a problem hiding this comment.
@Patrick-Erichsen saving this change for later?
|
|
||
| export const createRuleBlockImpl: ToolImpl = async ( | ||
| args: CreateRuleBlockArgs, | ||
| { name, rule, ...otherArgs }: CreateRuleBlockArgs, |
There was a problem hiding this comment.
what is the advantage over saying otherArgs syntax vs just saying { name, rule, description }
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Summary by cubic
Added a "Generate rule" button and dialog that lets users create new coding rules from chat history, with support for different rule types and streaming rule generation.