Skip to content

run shell path async to avoid blocking config load #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Jul 4, 2025

Description

getEnvPathFromUserShell was causing unresponsive extension host when loading MCP servers (stdio). Making it async solves this

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Summary by cubic

Loading the user shell PATH is now done asynchronously to prevent blocking the extension host during MCP server startup.

  • Refactors
    • Replaced sync shell PATH loading with async calls in MCP connection setup.
    • Updated related utility to use async execution.

@sestinj sestinj requested a review from a team as a code owner July 4, 2025 06:08
@sestinj sestinj requested review from tomasz-stefaniak and removed request for a team July 4, 2025 06:08
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit b7a9448
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/686eb25bf3d60d0008af2f7d
😎 Deploy Preview https://deploy-preview-6446--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 4, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 2 files and found no issues. Review PR in cubic.dev.

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2025
@Patrick-Erichsen
Copy link
Collaborator

Tests seem to be failing on a valid problem:

  context/mcp/MCPConnection.vitest.ts:88:48
     86|       };
     87| 
     88|       expect(() => new MCPConnection(options)).toThrow(
       |                                                ^
     89|         "Unsupported transport type: invalid",
     90|       );

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

⚠️ Conventional Commit Format

Your commit messages don't follow the conventional commit format, but this won't block your PR from being merged. We recommend downloading this extension if you are using VS Code.

Expected Format:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@RomneyDa RomneyDa merged commit 1a87532 into main Jul 10, 2025
78 of 80 checks passed
@RomneyDa RomneyDa deleted the nate/async-exec-shell-path branch July 10, 2025 23:01
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Jul 22, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants