-
Notifications
You must be signed in to change notification settings - Fork 3.4k
run shell path async to avoid blocking config load #6446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 2 files and found no issues. Review PR in cubic.dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Tests seem to be failing on a valid problem: ❯ context/mcp/MCPConnection.vitest.ts:88:48
86| };
87|
88| expect(() => new MCPConnection(options)).toThrow(
| ^
89| "Unsupported transport type: invalid",
90| ); |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
getEnvPathFromUserShell
was causing unresponsive extension host when loading MCP servers (stdio). Making it async solves thisChecklist
Summary by cubic
Loading the user shell PATH is now done asynchronously to prevent blocking the extension host during MCP server startup.