Skip to content

refactor: ♻️ Refactor to use a single animated ellipsis component #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2025
Merged

refactor: ♻️ Refactor to use a single animated ellipsis component #6459

merged 3 commits into from
Aug 5, 2025

Conversation

chezsmithy
Copy link
Contributor

@chezsmithy chezsmithy commented Jul 4, 2025 •
edited by cubic-dev-ai bot
Loading

Description

Refactor to use a single Animated Ellipsis component across the GUI. Allow future updates to a new more dynamic animation.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

Tested changes using visual inspection.

Summary by cubic

Replaced multiple animated ellipsis implementations with a single reusable AnimatedEllipsis component across the GUI.

  • Refactors
    • Moved ellipsis animation code to its own component.
    • Updated all references to use the new component.

@chezsmithy chezsmithy requested a review from a team as a code owner July 4, 2025 21:49
@chezsmithy chezsmithy requested review from sestinj and removed request for a team July 4, 2025 21:49
@netlify Netlify
Copy link

netlify bot commented Jul 4, 2025 •
edited
Loading

✅ Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 1af672c
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/686874593be48100086eb46d

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 4, 2025
sestinj
sestinj approved these changes Jul 5, 2025
View reviewed changes
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2025
@chezsmithy
Copy link
Contributor Author

@sestinj quick reminder on a merge for this guy.

@chezsmithy
Copy link
Contributor Author

@Patrick-Erichsen noticed you touched the color on the ellipsis in another PR. I'll see if I can rebase this. Still valuable?

@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Jul 24, 2025 •
edited
Loading

@chezsmithy yes, this still is great! I just updated the text color on the gui/src/components/mainInput/Lump/LumpToolbar/GeneratingIndicator.tsx. Good to merge once tests pass

@chezsmithy
Copy link
Contributor Author

chezsmithy commented Jul 28, 2025 •
edited
Loading

I need to check the color change is intact everywhere. - This is DONE.

sestinj
sestinj previously approved these changes Jul 28, 2025
View reviewed changes
@sestinj
Copy link
Contributor

sestinj commented Jul 31, 2025

@chezsmithy looks like there are type errors. i'm not sure if they are from merging in main or something else, but could you take a look?

@chezsmithy
Copy link
Contributor Author

@sestinj yep a merge consequence. The pipeline seems a bit unstable still but this looks like it's passing.

@RomneyDa RomneyDa merged commit 5c4f38b into continuedev:main Aug 5, 2025
36 of 37 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Aug 18, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RomneyDa RomneyDa RomneyDa approved these changes

@sestinj sestinj sestinj left review comments

Assignees

@Patrick-Erichsen Patrick-Erichsen

Labels
lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chezsmithy @Patrick-Erichsen @sestinj @RomneyDa