Skip to content

Conversation

tingwai
Copy link
Collaborator

@tingwai tingwai commented Aug 20, 2025

Description

[ What changed? Feel free to be brief. ]

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Keep the assistant menu open when clicking “Reload assistants” so you can refresh profiles without closing the dropdown. Other menu items still close the menu as before.

  • Bug Fixes

    • Stop click propagation on “Reload assistants” and trigger refreshProfiles, preventing the dropdown from closing.
  • Dependencies

    • Adjust zod in packages/openai-adapters/package-lock.json to ^3.23.8.

@tingwai tingwai requested a review from a team as a code owner August 20, 2025 20:34
@tingwai tingwai requested review from Patrick-Erichsen and removed request for a team August 20, 2025 20:34
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 20, 2025
scratchpad.txt Outdated
@@ -0,0 +1,5 @@
- [X] Find the code responsible for the "Reload assistants" button and menu behavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should be excluded from PR I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I missed that

@tingwai tingwai force-pushed the bot/keep-menu-open-reload branch from 6ff584f to a9735f5 Compare August 21, 2025 19:11
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 21, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants