Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Aug 22, 2025

Description

Continue streaming when a tool call is rejected. This PR introduces an experimental setting which will resume tool calls. It will skip the tool call if not necessary otherwise will try another approach.

resolves CON-2844

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

feat.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Enable continuing the conversation after a tool call is rejected. Adds an opt-in setting that treats canceled tool calls as complete and resumes streaming (CON-2844).

  • New Features
    • New UI setting: “Stream after tool rejection” (default off). Stored as ui.continueAfterToolRejection and added to shared config/types.
    • On cancel, appends a tool message (“User skipped the tool call”) and a “Tool Call Rejected” context item, then auto-continues the LLM response.
    • Tool-call completion logic considers “canceled” as done when the setting is enabled, so chats don’t get stuck.

@uinstinct uinstinct requested a review from a team as a code owner August 22, 2025 03:46
@uinstinct uinstinct requested review from tomasz-stefaniak and removed request for a team August 22, 2025 03:46
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 22, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 22, 2025
@uinstinct uinstinct requested a review from RomneyDa August 25, 2025 13:04
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2025
@RomneyDa RomneyDa merged commit 4b7af07 into continuedev:main Aug 27, 2025
66 of 83 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2025
@uinstinct uinstinct deleted the tool-call-skip branch August 28, 2025 03:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants