-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix: Remove completionOptions and appliedRules from PromptLog #7338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Remove completionOptions and appliedRules from PromptLog #7338
Conversation
I have read the CLA Document and I hereby sign the CLA agrabauskas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
@@ -456,7 +456,6 @@ export type FileSymbolMap = Record<string, SymbolWithRange[]>; | |||
export interface PromptLog { | |||
modelTitle: string; | |||
modelProvider: string; | |||
completionOptions: CompletionOptions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main change everything else is cleanup.
@etherandrius this looks good to me! Looks like waiting on CLA signing |
or maybe CLA bot glitched, rerunning |
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
#7337
Checklist
Summary by cubic
Removed completionOptions from PromptLog and dropped appliedRules tracking to simplify logs and shrink stored session data. Updated core LLM logging, Redux state/actions, and tests to match the new shape.