Fix: Remove applied rules from chat history #7343

etherandrius · 2025-08-22T18:49:18Z

Description

github-actions · 2025-08-22T18:49:28Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

agrabauskas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

etherandrius · 2025-08-22T18:50:27Z

gui/src/components/mainInput/belowMainInput/RulesPeek.tsx

+  const handleOpen = async () => {
+    if (rule.slug) {
+      void ideMessenger.request("controlPlane/openUrl", {
+        path: `${rule.slug}/new-version`,
+        orgSlug: undefined,
+      });
+    } else if (rule.ruleFile) {
+      ideMessenger.post("openFile", {
+        path: rule.ruleFile,
+      });
+    } else if (
+      rule.source === "default-chat" ||
+      rule.source === "default-plan" ||
+      rule.source === "default-agent"
+    ) {
+      ideMessenger.post("openUrl", DEFAULT_SYSTEM_MESSAGES_URL);
+    } else {
+      ideMessenger.post("config/openProfile", {
+        profileId: undefined,
+        element: { sourceFile: (rule as any).sourceFile },
+      });
    }
  };


This is not ideal, but it's consistent with RuleCard: React.FC<RuleCardProps> on click will just open the rules files in the editor.

RomneyDa

@etherandrius could you add some explanation/context in the description?

etherandrius · 2025-08-22T19:41:50Z

@RomneyDa linked back to the issue

RomneyDa

@etherandrius see nitpick
Also could we create a little util such as openRule that takes a RuleWithSource or AppliedRule so you could share all the rule opening logic between the components?
Overall agree with this, will be nice to reduce UI a bit here too

RomneyDa · 2025-08-27T18:23:32Z

core/index.d.ts

  conversationSummary?: string;
 }

+export interface AppliedRule {


Can use Omit<RuleWithSource, "rule">

etherandrius · 2025-08-28T10:24:52Z

gui/src/components/mainInput/Lump/sections/RulesSection.tsx

 const RuleCard: React.FC<RuleCardProps> = ({ rule }) => {
  const dispatch = useAppDispatch();
-  const ideMessenger = useContext(IdeMessengerContext);
-  const mode = useAppSelector((store) => store.session.mode);


etherandrius · 2025-08-28T10:25:56Z

gui/src/components/mainInput/Lump/sections/RulesSection.tsx

@@ -29,10 +29,33 @@ interface RuleCardProps {
  rule: RuleWithSource;
 }

+export const openRules = async (rule: Omit<RuleWithSource, "rule">) => {
+  const ideMessenger = useContext(IdeMessengerContext);


ideMessenger this was define outside the function before. I assume the useContext(IdeMessengerContext) call is basically free and we can call it inside the function.

Will need to pass ideMessenger for this one since can't use hooks outside of top level of component

etherandrius · 2025-08-28T11:00:50Z

gui/src/redux/thunks/streamNormalInput.ts

@@ -282,7 +282,7 @@ export const streamNormalInput = createAsyncThunk<
            ...(appliedRules.length > 0 && {
              rules: appliedRules.map((rule) => ({
                id: getRuleId(rule),
-                rule: rule.rule,
+                rule: "", // TODO: remove rule key from type. The contents should be present in the prompt


a bit funky.

Any specific reason to remove rules from dev data? Have you had issues with verbose dev data?

etherandrius · 2025-08-28T11:09:25Z

core/llm/rules/getSystemMessageWithRules.ts

+    appliedRules: rules.map(fullRule => {
+      const { rule, ...rest } = fullRule // destruct rule key
+      return rest;
+    }),


A bit funky as well.

Ideally this method would not take availableRules: Omit<RuleWithSource, "rule">[] and read rules from the file.
This would also fix the issue of rules sometimes being outdated <- maybe a FLUP.

This function could still just return RuleWithSource, shouldn't effect storage if omitted at the point of redux

note that config should reload if a rule file is updated, so should be up to date in most cases

RomneyDa

Main blocking feedback is to remove use of useContext in utility function
create new type with Omit and pass the new type around to prevent duplicate Omits
Leave rule content on dev data unless specific issues with dev data storage - let me know your thoughts on this?

RomneyDa · 2025-09-03T22:33:11Z

gui/src/components/mainInput/Lump/sections/RulesSection.tsx

@@ -29,10 +29,33 @@ interface RuleCardProps {
  rule: RuleWithSource;
 }

+export const openRules = async (rule: Omit<RuleWithSource, "rule">) => {
+  const ideMessenger = useContext(IdeMessengerContext);


Will need to pass ideMessenger for this one since can't use hooks outside of top level of component

RomneyDa · 2025-09-03T22:35:51Z

core/index.d.ts

@@ -497,7 +497,7 @@ export interface ChatHistoryItem {
  toolCallStates?: ToolCallState[];
  isGatheringContext?: boolean;
  reasoning?: Reasoning;
-  appliedRules?: RuleWithSource[];
+  appliedRules?: Omit<RuleWithSource, "rule">[];


Can keep the AppliedRule type and just say type AppliedRule = Omit<RuleWithSource, "rule"> to prevent having Omits all over

RomneyDa · 2025-09-03T22:38:01Z

core/llm/rules/getSystemMessageWithRules.ts

+    appliedRules: rules.map(fullRule => {
+      const { rule, ...rest } = fullRule // destruct rule key
+      return rest;
+    }),


This function could still just return RuleWithSource, shouldn't effect storage if omitted at the point of redux

note that config should reload if a rule file is updated, so should be up to date in most cases

RomneyDa · 2025-09-03T22:38:49Z

gui/src/components/mainInput/Lump/sections/RulesSection.tsx

@@ -29,10 +29,33 @@ interface RuleCardProps {
  rule: RuleWithSource;
 }

+export const openRules = async (rule: Omit<RuleWithSource, "rule">) => {


could take RuleWithSource | AppliedRule

RomneyDa · 2025-09-03T22:39:33Z

gui/src/redux/thunks/streamNormalInput.ts

@@ -282,7 +282,7 @@ export const streamNormalInput = createAsyncThunk<
            ...(appliedRules.length > 0 && {
              rules: appliedRules.map((rule) => ({
                id: getRuleId(rule),
-                rule: rule.rule,
+                rule: "", // TODO: remove rule key from type. The contents should be present in the prompt


Any specific reason to remove rules from dev data? Have you had issues with verbose dev data?

Fix: Remove applied rules from chat history

b28102e

etherandrius requested a review from a team as a code owner August 22, 2025 18:49

etherandrius requested review from RomneyDa and removed request for a team August 22, 2025 18:49

github-project-automation bot added this to Issues and PRs Aug 22, 2025

github-project-automation bot moved this to Todo in Issues and PRs Aug 22, 2025

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 22, 2025

etherandrius commented Aug 22, 2025

View reviewed changes

RomneyDa requested changes Aug 22, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 22, 2025

etherandrius mentioned this pull request Aug 22, 2025

Session storage can grow too large. #7337

Open

4 tasks

nit

bed4c81

RomneyDa requested changes Aug 27, 2025

View reviewed changes

Omit type, share code

fb2c683

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 28, 2025

etherandrius commented Aug 28, 2025

View reviewed changes

actually remove the rule contents

331c81f

etherandrius commented Aug 28, 2025

View reviewed changes

nit

936723a

RomneyDa requested changes Sep 3, 2025

View reviewed changes

Fix: Remove applied rules from chat history #7343

Are you sure you want to change the base?

Fix: Remove applied rules from chat history #7343

Conversation

etherandrius commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RomneyDa left a comment

Choose a reason for hiding this comment

Uh oh!

etherandrius commented Aug 22, 2025

Uh oh!

RomneyDa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etherandrius Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RomneyDa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

etherandrius commented Aug 22, 2025 •

edited

Loading

RomneyDa left a comment •

edited

Loading

etherandrius Aug 28, 2025 •

edited

Loading