Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Aug 24, 2025

Description

Continuation of #7267

Adds nice diff UI for the new find and replace tools:
image

image

Summary by cubic

Adds a collapsible diff view for find-and-replace tools so users can preview changes inline and accept/reject them without leaving the chat. Also preloads file content to generate accurate diffs and smoother UX.

  • New Features

    • Diff UI for SingleFindAndReplace and MultiEdit with +/- highlighting, error/empty states, status icon (click to view output), file open on click, and ApplyActions for accept/reject; auto-expands when status is "generated".
    • Accurate previews by preloading file content into parsedArgs (enhanceParsedArgs) and updating tool impls to use editingFileContents across single/multi/search-replace.
    • Replaces placeholder EditFile rendering in FunctionSpecificToolCallDiv; adds focused tests for FindAndReplaceDisplay.
  • Dependencies

    • Added diff and @types/diff.

@RomneyDa RomneyDa requested a review from a team as a code owner August 24, 2025 00:01
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team August 24, 2025 00:01
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 24, 2025
Copy link

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

Copy link

AI Code Review

AI review completed but failed to parse output

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 issues found across 14 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@chezsmithy
Copy link
Contributor

This is super cool. One of my favorite things about continue is how it uses the chat so effectively vs other tools.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Aug 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 25, 2025
@tomasz-stefaniak tomasz-stefaniak merged commit ff931ec into dallin/search_and_replace_makeover Aug 25, 2025
3 checks passed
@tomasz-stefaniak tomasz-stefaniak deleted the dallin/diff-UI branch August 25, 2025 19:55
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Aug 25, 2025
@sestinj
Copy link
Contributor

sestinj commented Aug 25, 2025

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Aug 27, 2025

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:XL This PR changes 500-999 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants