Confirm is valid for the given grid, not global. #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Veszter-007 Please, fix indent. |
Confirm is valid for the given grid, not global.
|
@radimvaculik Thanks for the feedback, I've fixed the indentation! |
|
LGTM. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the confirm plugin to validate and handle confirmation events only for elements within the specific datagrid instance, rather than handling all global confirmation events.
- Replaces
bind(datagrid)withcall(datagrid, confirmEl, e)for direct click event handlers - Adds a containment check for AJAX interaction events to ensure they belong to the current datagrid
- Updates parameter passing to use the actual confirmation element instead of the event target
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@f3l1x Please, check it. |
Hi there! Apologies for the delay in getting back to this — I’ve been a bit tied up lately. Thanks a lot for the suggested change. I’ve reviewed it and it looks great to me. I’ve committed the update and tested it on my end, and everything seems to be working fine. Let me know if there’s anything else I should adjust! Co-authored-by: Copilot <[email protected]>
|
@f3l1x Ping. LGTM. Please, merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.