Skip to content

Fix: trying to use emojis with an uppercase letter breaks the message field #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: trying to use emojis with an uppercase letter breaks the message field #3560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/headless/plugins/emoji/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const emojis = {
converse.emojis.shortnames = converse.emojis.list.map((m) => m.sn);
const getShortNames = () =>
converse.emojis.shortnames.map((s) => s.replace(/[+]/g, '\\$&')).join('|');
converse.emojis.shortnames_regex = new RegExp(getShortNames(), 'gi');
converse.emojis.shortnames_regex = new RegExp(getShortNames(), 'g');
converse.emojis.initialized_promise.resolve();
}
return converse.emojis.initialized_promise;
Expand Down
4 changes: 2 additions & 2 deletions src/headless/plugins/emoji/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export function getShortnameReferences (text) {
}
const references = [...text.matchAll(converse.emojis.shortnames_regex)].filter(ref => ref[0].length > 0);
return references.map(ref => {
const cp = converse.emojis.by_sn[ref[0].toLowerCase()].cp;
const cp = converse.emojis.by_sn[ref[0]].cp;
return {
cp,
'begin': ref.index,
Expand Down Expand Up @@ -190,7 +190,7 @@ export function isOnlyEmojis (text) {
}
const emojis = words.filter(text => {
const refs = getCodePointReferences(u.shortnamesToUnicode(text));
return refs.length === 1 && (text.toLowerCase() === refs[0]['shortname'] || text === refs[0]['emoji']);
return refs.length === 1 && (text === refs[0]['shortname'] || text === refs[0]['emoji']);
});
return emojis.length === words.length;
}
Expand Down
Loading