-
-
Notifications
You must be signed in to change notification settings - Fork 798
WIP: Split OMEMO plugin into view and headless components (second attempt) #3635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This replaces 'plugins/omemo' with 'plugins/omemo-views' and 'headless/plugins/omemo'.
So that it gets detected and registered as a plugin, but unfortunately it still doesn't seem to be doing that? :(
Wait I rebased against the wrong thing sorry! Will be back. |
Please do not touch this yet as I will be force-pushing something soon. |
Hi, I am trying to use OMEMO encryption in the headless version of Converse, I tried many things, but couldn't succeed. |
Hi! OMEMO encryption is not yet supported in headless. You need to wait till the PR is complete. Actually, it starts off some work I did quite a while ago at #3117. I need rebase to the latest master and handle all the merge conflicts, then make a few more changes to make it work. |
@badrihippo: Any progress on it? |
@Neustradamus I don't want to promise anything because I've done that multiple times in the past 😬 but thanks in part to your nudge I have started on rebasing this entire thing to the new |
Thanks a lot, looking forward to |
Hi @badrihippo, did you get time to finish up things? |
Hi @MirwaisAkrami, I am still working on the rebase as quite a few things have changed (at to be honest I've only managed to put in about 2-3 hours the past week due to being busy with client work). The good news is that I just got awarded a grant from NLnet to develop Convo! The details are yet to be finalised but this PR is likely to be on top of the priority list to get OMEMO working. In terms of timelines: I am keeping January 2026 free to work on Convo so the worst case is to have this completed my mid-January. I feel a bit silly saying this because that's a long way away and this is not such a large task but it's mainly about my ability to set aside the time; I'm already balancing two client projects at the moment. I am going home this week to spend time with family, let's see if I can work on this as well during that time 🤞 Would you like to join the chatroom [email protected]? I will be posting more regular updates there. It's mainly centred around Convo but this is one of the pending tasks there and I'm also interested to hear what you were planning to use this feature for, so you can tell me about it there! |
Opening a new pull request as I'm coming back to this after a while. This PR supersedes and continues the work of #3117. The first commit here is basically a squash-and-rebase of the earlier PR.
This PR replaces
src/omemo
withplugins/omemo-views
andheadless/plugins/omemo
. The way I'm working on this is to keep everything onomemo-views
for now, and then gradually move whatever possible out to the headlessomemo
.Files to be tackled (more will be added as events warrant):
omemo
plugin separatelyStandard steps to finish before completing pull request:
CHANGES.md
document it in
docs/source/configuration.rst
with
make check
or you can run them in the browser by runningmake serve
and then opening
http://localhost:8000/tests.html
.