Skip to content

Conversation

HuijingHei
Copy link
Member

This config is setup to target downstream job automation.

Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'bootupd-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'bootupd-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'bootupd-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command config validate or our pre-commit hooks for validation of the configuration.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an initial packit configuration for automating downstream packaging. The configuration has a few issues that could prevent it from working as intended. I've identified a couple of critical issues related to the spec file handling and job triggers that need to be addressed. I've also included some suggestions to improve the configuration's maintainability and use packit's features more effectively. My feedback focuses on establishing a clear source of truth for the spec file and ensuring the job triggers are correctly configured for the desired workflow.

.packit.yaml Outdated
Comment on lines 20 to 21
post-upstream-clone:
- wget https://src.fedoraproject.org/rpms/rust-bootupd/blob/rawhide/f/rust-bootupd.spec

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The post-upstream-clone action downloads the spec file from the Fedora rawhide branch. This will overwrite any spec file present in this repository, making local changes to the spec file ineffective. This action should be removed to use the spec file from this repository as the source of truth. This also makes the configuration simpler and avoids a circular dependency where the spec file is fetched from downstream and then proposed back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, wow. Yes I think this is probably right.

Though honestly I still disagree with packit's focus on maintaining spec files in upstream by default. It's convenient for projects that are mainly Fedora-derivative only. There's just a deep fundamental conflict with distros owning their build rules.

IOW, yes we can probably drop this if we're maintaining the spec upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should use contrib/packaging/bootupd.spec instead.

- fedora-all

- job: bodhi_update
trigger: commit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The bodhi_update job is currently triggered on commit. This will cause it to run for every commit to a dist-git branch, even before a build has been completed in Koji, which will likely lead to failures. This job should be triggered after a successful Koji build.

  trigger: koji_build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants