-
Notifications
You must be signed in to change notification settings - Fork 0
feat(storage): implement lifecycle transitions #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ab1011c
to
ce9d376
Compare
ce9d376
to
d23bdcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements lifecycle transitions for object storage buckets by adding support for transitioning objects between storage classes. The implementation includes schema definitions, API integration, validation, and comprehensive test coverage.
Key changes:
- Add transition block support to lifecycle rules with date/days/storage_class fields
- Integrate validation for transition timing and storage class parameters
- Include test coverage for transition-only lifecycle rules
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
go.mod | Adds terraform-plugin-framework-validators dependency for input validation |
examples/resources/coreweave_object_storage_bucket_versioning/resource.tf | Removes trailing whitespace from example |
coreweave/object_storage/resource_bucket_lifecycle_configuration_test.go | Adds test case for transition-only lifecycle rules |
coreweave/object_storage/resource_bucket_lifecycle_configuration.go | Implements transition schema, validation, API integration, and state management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
coreweave/object_storage/resource_bucket_lifecycle_configuration.go
Outdated
Show resolved
Hide resolved
coreweave/object_storage/resource_bucket_lifecycle_configuration.go
Outdated
Show resolved
Hide resolved
7df6eaf
to
dfff697
Compare
91cf9f8
to
a36a9fc
Compare
a1295bd
to
c013c95
Compare
c013c95
to
e49162c
Compare
Adds storage class transition lifecycle rule configuration options for both current and noncurrent objects.