-
Notifications
You must be signed in to change notification settings - Fork 827
Remove references to max_series_per_query
from docs
#6889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -318,11 +318,10 @@ overrides: | |
tenant1: | ||
ingestion_rate: 10000 | ||
max_series_per_metric: 100000 | ||
max_series_per_query: 100000 | ||
max_fetched_series_per_query: 10000 | ||
tenant2: | ||
max_samples_per_query: 1000000 | ||
max_series_per_metric: 100000 | ||
max_series_per_query: 100000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it should be max_fetched_series_per_query for consistency There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤦 , thanks for pointing this out. |
||
max_fetched_series_per_query: 100000 | ||
|
||
multi_kv_config: | ||
mirror_enabled: false | ||
|
@@ -348,11 +347,10 @@ overrides: | |
tenant1: | ||
ingestion_rate: 10000 | ||
max_series_per_metric: 100000 | ||
max_series_per_query: 100000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
max_fetched_series_per_query: 100000 | ||
tenant2: | ||
max_samples_per_query: 1000000 | ||
max_series_per_metric: 100000 | ||
max_series_per_query: 100000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
max_fetched_series_per_query: 100000 | ||
``` | ||
|
||
Valid per-tenant limits are (with their corresponding flags for default values): | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,5 +8,4 @@ overrides: | |
max_global_series_per_user: 300000 | ||
max_series_per_metric: 0 | ||
max_series_per_user: 0 | ||
max_samples_per_query: 100000 | ||
max_series_per_query: 100000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
max_fetched_series_per_query: 100000 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,9 +35,8 @@ overrides: | |
max_global_series_per_metric: 300000 | ||
max_global_series_per_user: 300000 | ||
max_series_per_metric: 0 | ||
max_series_per_user: 0 | ||
max_samples_per_query: 100000 | ||
max_series_per_query: 100000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
max_series_per_user: | ||
exitmax_fetched_series_per_query: 100000 | ||
``` | ||
|
||
The `overrides-exporter` is configured to run as follows: | ||
|
@@ -59,7 +58,6 @@ cortex_overrides{limit_name="max_global_series_per_user",user="user1"} 300000 | |
cortex_overrides{limit_name="max_local_series_per_metric",user="user1"} 0 | ||
cortex_overrides{limit_name="max_local_series_per_user",user="user1"} 0 | ||
cortex_overrides{limit_name="max_samples_per_query",user="user1"} 100000 | ||
cortex_overrides{limit_name="max_series_per_query",user="user1"} 100000 | ||
``` | ||
|
||
With these metrics, you can set up alerts to know when tenants are close to hitting their limits | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably change
max_series_per_query
tomax_fetched_series_per_query
as it is the new limit.