Added corbench code without manifest files #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKongers
force-pushed
the
add-corbench-code-without-manifests
branch
2 times, most recently
from
9ccc8e7 to
d9df051
Compare
yeya24
reviewed
Aug 8, 2025
| @@ -0,0 +1,16 @@ | |||
| FROM --platform=linux/amd64 golang:1.15-alpine | |||
There was a problem hiding this comment.
Can we use newer version of golang?
| name: gp2-csi | ||
| provisioner: ebs.csi.aws.com | ||
| parameters: | ||
| type: gp2 |
There was a problem hiding this comment.
I could use gp3, but i wonder if it will break, i will give it a test
| @@ -0,0 +1,18 @@ | |||
| # Build stage | |||
| FROM golang:1.15-alpine AS builder | |||
|
|
||
| type Resource = provider.Resource | ||
|
|
||
| type eksCluster struct { |
There was a problem hiding this comment.
Do we really need these code? Can we just import prombench as a library
| "github.com/cortexproject/test-infra/corbench/pkg/provider" | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
ditto. If we cannot reuse prombench CLI, let's try to use its library instead of copy its code directly.
| set -e | ||
|
|
||
| # Disable AWS CLI pager to prevent interactive prompts | ||
| export AWS_PAGER="" |
There was a problem hiding this comment.
It is ok to keep this script for now but we should try to just configure EBS CSI addon in the same eks cluster yaml
There was a problem hiding this comment.
I will add a note
Signed-off-by: Eric Kong <[email protected]>
Signed-off-by: Eric Kong <[email protected]>
TheKongers
force-pushed
the
add-corbench-code-without-manifests
branch
from
7b7312f to
4b48209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved over all corbench code from https://github.com/TheKongers/Corbench without the manifest files.
NOTE: the files under the directories
/corbench/infraand/corbench/pkgare directly from prombench, but trimmed down to only keep the EKS functionality to make it more lightweight.