add SEED token #6708
Draft
add SEED token #6708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutron/assetlist.json
Outdated
| }, | ||
| "images": [ | ||
| { | ||
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/neutron/images/seed.png" |
There was a problem hiding this comment.
the image needs to be uploaded
There was a problem hiding this comment.
I think it`s done now:
There was a problem hiding this comment.
That's a different repo. The image needs to be uploaded to this repo--at the URL mentioned in the "png" field (currently would be a broken link)
There was a problem hiding this comment.
Oh, please excuse me. Does it look normal now?
There was a problem hiding this comment.
Not quite. In addition to the URI needing to be valid, the image also has to be uploaded to this repo. If we were to allow referencing another repo, if that repo changes, the URI could break in the future
Signed-off-by: subAtom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.