-
Notifications
You must be signed in to change notification settings - Fork 113
fix(mempool): align temporary rejection check with TxTracker #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
almk-dev
wants to merge
21
commits into
vlad/integrate-txtracker
Choose a base branch
from
abdul/align-temp-reject
base: vlad/integrate-txtracker
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+210
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (63.92%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## vlad/integrate-txtracker #802 +/- ##
============================================================
- Coverage 65.18% 63.92% -1.26%
============================================================
Files 320 320
Lines 21864 21989 +125
============================================================
- Hits 14252 14057 -195
- Misses 6426 6563 +137
- Partials 1186 1369 +183
🚀 New features to boost your workflow:
|
1e4f608 to
6c4a6b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SentRawTransaction()tocall_tx.goto be alongsideSendTransaction()IsTemporaryErr()to string match and check for nonce gapIsTemporaryErr()check to both the response rawLog as well as the errorCloses: #493
Author Checklist
I have...
mainbranch