Skip to content

Conversation

@almk-dev
Copy link
Member

@almk-dev almk-dev commented Nov 4, 2025

Description

  • Adds logic from @mmsqe's fix: align temporary reject check for included tx from txpool #494 and integrates TxTracker changes
  • Moves SentRawTransaction() to call_tx.go to be alongside SendTransaction()
  • Updates IsTemporaryErr() to string match and check for nonce gap
  • Removes redundant pool error vars in favor of imports from geth
  • Adds IsTemporaryErr() check to both the response rawLog as well as the error

Closes: #493


Author Checklist

I have...

@almk-dev almk-dev changed the base branch from main to vlad/integrate-txtracker November 4, 2025 20:57
@almk-dev almk-dev changed the title Abdul/align temp reject fix(mempool): align temporary rejection check with TxTracker Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 32.20339% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.92%. Comparing base (0cf0816) to head (17cea3d).

Files with missing lines Patch % Lines
rpc/backend/call_tx.go 32.35% 40 Missing and 29 partials ⚠️
mempool/txpool/locals/errors.go 30.00% 6 Missing and 1 partial ⚠️
mempool/txpool/legacypool/legacypool.go 33.33% 3 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (63.92%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           vlad/integrate-txtracker     #802      +/-   ##
============================================================
- Coverage                     65.18%   63.92%   -1.26%     
============================================================
  Files                           320      320              
  Lines                         21864    21989     +125     
============================================================
- Hits                          14252    14057     -195     
- Misses                         6426     6563     +137     
- Partials                       1186     1369     +183     
Files with missing lines Coverage Δ
rpc/backend/sign_tx.go 12.00% <ø> (-39.73%) ⬇️
mempool/txpool/legacypool/legacypool.go 65.92% <33.33%> (-17.93%) ⬇️
mempool/txpool/locals/errors.go 30.76% <30.00%> (-69.24%) ⬇️
rpc/backend/call_tx.go 43.16% <32.35%> (-15.59%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@almk-dev almk-dev force-pushed the abdul/align-temp-reject branch from 1e4f608 to 6c4a6b2 Compare November 7, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants