feat: redesign bank precompile for erc20 support #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: cosmos#505 Supersedes: cosmos#517 Use go-abi to simplify implementation. update erc20 source
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+62
to
+64
| for k, v := range generator.ParseExternalTuples(*extTuplesFlag) { | ||
| extTuples[k] = v | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+112
to
+117
| for denom, amount := range m { | ||
| coin := sdk.NewCoin(denom, sdkmath.NewInt(amount)) | ||
| if cb(coin) { | ||
| break | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+122
to
+127
| for denom, amount := range k.supplies { | ||
| coin := sdk.NewCoin(denom, sdkmath.NewInt(amount)) | ||
| if cb(coin) { | ||
| break | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (63.63%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
- Coverage 65.17% 63.63% -1.54%
==========================================
Files 317 322 +5
Lines 21600 23141 +1541
==========================================
+ Hits 14078 14726 +648
- Misses 6345 7150 +805
- Partials 1177 1265 +88
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #505
Supersedes: #517
Use go-abi to simplify implementation, see: #789
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch