-
Notifications
You must be signed in to change notification settings - Fork 0
feat: clean notifications #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated files after a yarn build.
Changes not related to this PR
cowdan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments, otherwise lgtm
anxolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is a neat solution!
I didn't know there was a cron in strapi, I thought you were adding it in GH. This is way better, and more secure so we don't need to give GH actions deletion access/
Thanks for fixing this
Summary
notificationswhosenotification-templatedueDate is paste > 1 weeknotificationswhen anotification-templateis removedTesting
notification-templates, where:notificationfor eachnotification-templatenotificationwithout anotification-template*/1 * * * *) and start the dev servernotification-templateshould have been removednotification-templateusing the admin panelnotificationshould be removed as well