feat: delete notifications in batches of 1k #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Merging to test right away, please post merge review |
anxolin
reviewed
Mar 14, 2025
| where: { | ||
| id: { | ||
| $in: expiredNotifications.map((n) => n.id), | ||
| const BATCH_SIZE = 1000; |
Contributor
There was a problem hiding this comment.
maybe you want to move this to the top f the file?
Contributor
There was a problem hiding this comment.
ignore, since it has been merged and is not important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #58, it's possible to see that the cleanup is failing because too much is being deleted at once.
This change splits it into 1k batches.
Testing
Same as #58