Update batch auction documentation #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bram-vdberg
commented
Feb 6, 2025
bram-vdberg
commented
Feb 6, 2025
bram-vdberg
commented
Feb 6, 2025
harisang
reviewed
Feb 11, 2025
harisang
reviewed
Feb 11, 2025
harisang
reviewed
Feb 12, 2025
harisang
reviewed
Feb 12, 2025
harisang
reviewed
Feb 12, 2025
| - `protocolFees`: array of any protocol fee policies that apply to the order. | ||
| - `quote`: the winning quote for that order. | ||
|
|
||
| We clarify here that all `market` and `liquidity` orders have a potentially non-zero predetermined fee, while all `limit` orders have necessarily a zero signed fee, and the actual fee charged to the order is computed and provided by the solvers when they propose an execution of such an order. More details are provided in the [solutions section](#solutions-output). |
Contributor
There was a problem hiding this comment.
I saw you removed 'liquidity' as an option in the class of orders. Not sure if this is still around, but if we decide to remove it, then this sentence needs to be corrected as well as it references such orders
Contributor
Author
There was a problem hiding this comment.
I followed the openapi from the driver: https://github.com/cowprotocol/services/blob/7333e77082a0fe7a6b0025aff248b1fb52f3c8ba/crates/driver/openapi.yml#L190
I saw that liquidity was removed there, so I assumed it was removed.
harisang
reviewed
Feb 12, 2025
Co-authored-by: Haris Angelidakis <[email protected]>
harisang
approved these changes
Feb 19, 2025
cowmarketing
approved these changes
Feb 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the batch auction documentation