-
Notifications
You must be signed in to change notification settings - Fork 24
CiP-74 Align solver and protocol incentives #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR updates protocol docs: adds CIP-74 to solver competition rewards, clarifies cap parameter definitions (defining c_u as the protocol fee and c_l as a chain-specific cap) and simplifies per-chain cap entries; and revises governance fees — lowering surplus/quote caps from 1% to 0.98% and changing the Volume Fee from 10 bps to 2 bps while broadening its scope to all orders. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The changes correctly reflect the current state of the proposed CIP. |
|
Reduced price improvement fee to 0.98% of volume to leave the total maximum protocol fee capped at 1% |
pretf00d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tweak requested.
clarify which protocol fee is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
-
docs/cow-protocol/reference/core/auctions/rewards.md(2 hunks)
🔇 Additional comments (3)
docs/cow-protocol/reference/core/auctions/rewards.md (3)
7-8: Good incorporation of CIP-74 and improved wording.The introductory paragraph now includes CIP-74 and reflects the community feedback from previous reviews. The wording clarifies the dual nature of solver rewards (competition and price estimation) and reads more naturally.
15-15: Section header properly updated for CIP-74.The header now consistently reflects the CIP-74 reference added to the introduction.
39-39: Clear clarification of multi-solution aggregation.The rewording explicitly specifies that
$$c_u$$ includes protocol fees from "all solutions supplied by the solver in that auction," directly resolving the ambiguity raised in previous reviews about multiple solutions from a single solver.
Remove inconsistent variable names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/cow-protocol/reference/core/auctions/rewards.md (1)
19-23: Minor phrasing refinement suggested for the new protocol-execution note.The new note appropriately clarifies that on-chain solutions must match the solver's off-chain commitment. However, the phrasing "From the protocol's perspective" is slightly informal. Consider a more direct phrasing, such as:
"A solution executed on chain must equal the solver's initial commitment" or "The protocol requires that on-chain executions match the solver's off-chain commitment."
This change would make the requirement more explicit without the anthropomorphic framing.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
-
docs/cow-protocol/reference/core/auctions/rewards.md(2 hunks)
🔇 Additional comments (3)
docs/cow-protocol/reference/core/auctions/rewards.md (3)
7-8: Intro text successfully incorporates CIP-74 and prior feedback.The reworded intro paragraph includes the CIP-74 reference and appears to reflect the suggestion from previous reviews to clarify the nature of solver rewards. The text is clear and well-structured.
15-15: Section header correctly updated to include CIP-74.
39-46: Per-chain cap formatting now consistently presented — resolves prior inconsistency.This change successfully addresses the inconsistency flagged in previous reviews. All per-chain cap entries now use a uniform bare-value format (e.g., "Lens:
$$10 ;\textrm{GHO}$$ " without explicit parameter labels), making the list coherent and reducing ambiguity. The clarified description on line 39 establishes that all listed values represent$$c_l$$ (the chain-specific lower cap).
Description
Proposed specification for https://forum.cow.fi/t/cip-draft-align-solver-rewards-with-protocol-revenue/3174
Changes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.