feat(new-chains): add linea #558
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds the Linea network (and adds Plasma in one frontend mapping) across documentation and a frontend explorer mapping: network lists, token/address tables, auction parameters, tutorial examples, and Changes
Sequence Diagram(s)(No sequence diagrams — changes are documentation and static mapping additions; no control-flow changes to visualize.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
docs/cow-amm/tutorials/cow-amm-deployer.md(1 hunks)docs/cow-amm/tutorials/cow-amm-for-solvers.md(1 hunks)docs/cow-protocol/reference/contracts/core/README.mdx(1 hunks)docs/cow-protocol/reference/contracts/periphery/README.mdx(4 hunks)docs/cow-protocol/reference/core/auctions/competition_rules.md(2 hunks)docs/cow-protocol/reference/core/auctions/rewards.md(1 hunks)docs/cow-protocol/reference/core/signing_schemes.mdx(2 hunks)docs/cow-protocol/tutorials/cow-swap/custom-links.md(1 hunks)docs/cow-protocol/tutorials/solvers/local_test.md(1 hunks)docs/cow-protocol/tutorials/widget/widget.md(14 hunks)docs/governance/token.md(2 hunks)src/components/contract-addresses/index.tsx(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-16T16:45:56.918Z
Learnt from: alfetopito
Repo: cowprotocol/docs PR: 505
File: docs/cow-protocol/tutorials/cow-swap/custom-links.md:75-76
Timestamp: 2025-06-16T16:45:56.918Z
Learning: Polygon completed a major token migration from MATIC to POL on September 4, 2024. As part of this upgrade, the wrapped token symbol on Polygon PoS was automatically changed from WMATIC to WPOL (Wrapped Polygon Ecosystem Token). The contract address 0x0d500b1d8e8ef31e21c99d1db9a6444d3adf1270 on Polygon now represents WPOL, not WMATIC.
Applied to files:
docs/cow-protocol/tutorials/cow-swap/custom-links.md
🔇 Additional comments (19)
docs/cow-amm/tutorials/cow-amm-deployer.md (1)
23-23: LGTM!The Linea entry is correctly added to the factory contract addresses list, maintaining consistency with the existing format and properly marked as N/A to indicate no deployment yet.
docs/cow-protocol/tutorials/solvers/local_test.md (1)
65-66: LGTM!The Linea orderbook URLs follow the established pattern and are correctly positioned in the table, maintaining consistency with other network entries.
docs/cow-protocol/reference/core/signing_schemes.mdx (2)
48-48: LGTM!The Linea entry is correctly added to the explorerLinks array for the domain separator function, maintaining consistency with the settlement contract deployment across all supported chains.
136-136: LGTM!The Linea entry is appropriately marked as N/A in the helper contract section, consistent with other chains that don't have this helper contract deployed yet.
src/components/contract-addresses/index.tsx (3)
14-14: LGTM!The Linea explorer URL is correctly added to the explorerByChain mapping, consistent with its usage throughout the documentation files.
2-2: Minor formatting changes noted.The whitespace and formatting adjustments (React import spacing, conditional formatting, JSX prop spacing) are stylistic and don't affect functionality.
Also applies to: 53-53, 61-61, 64-64
15-15: The Plasma network addition is legitimate and correctly implemented.Verification confirms that Plasma is a real blockchain network with plasmascan.to as its official explorer URL. The entry is properly formatted and consistent with other networks in the
explorerByChainconfiguration object. This is a code configuration file, not documentation, and other networks here also lack individual comments. The technical implementation is correct with no issues requiring fixes.docs/cow-protocol/reference/core/auctions/competition_rules.md (1)
45-46: LGTM!The Linea deadline is set to 20 blocks, consistent with Base, Avalanche, and Polygon. The infrastructure configuration reference is helpful for future maintenance.
docs/cow-protocol/tutorials/cow-swap/custom-links.md (1)
79-79: Verification confirmed—no changes needed.The token address
0xe5D7C2a44FfDDf6b295A15c148167daaAf5Cf34fand explorer URLhttps://lineascan.buildare both correct. The verification successfully retrieved the token page, confirming it's Wrapped Ether (WETH) on Linea mainnet with active contract data.docs/cow-protocol/reference/contracts/core/README.mdx (1)
47-49: All core contracts are confirmed deployed on Linea.Verification completed successfully. All three contracts are found on the Linea network at the specified addresses:
- GPv2Settlement: ✓ Deployed
- GPv2AllowListAuthentication: ✓ Deployed
- GPv2VaultRelayer: ✓ Deployed
The explorer links in the documentation are valid and the changes are safe to merge.
docs/cow-protocol/reference/contracts/periphery/README.mdx (3)
41-61: Verify HooksTrampoline restructuring intent and address accuracy.The refactoring extracts a "Most chains" subsection with the original address and adds a separate Linea subsection with a different address (0xeFcf0d30DB41Ae0b136c5E3B4340dFeE2D099Ada). This assumes Linea uses a distinct deployment. Ensure:
- This is intentional (Linea HooksTrampoline indeed has a different address).
- The address 0xeFcf0d30DB41Ae0b136c5E3B4340dFeE2D099Ada is verified as correct for Linea.
- The
explorerLinks("Linea", ...)call on line 60 is properly supported by the explorer registry (verify insrc/components/contract-addresses/index.tsx).
17-18: Verify Linea contract addresses for EthFlow.Lines 17–18 add Linea to the EthFlow Production and Staging rows. Confirm that:
- Address
0xbA3cB449bD2B4ADddBc894D8697F5170800EAdeCis the correct EthFlow Production deployment on Linea.- Address
0x04501b9b1D52e67f6862d157E00D13419D2D6E95is the correct EthFlow Staging deployment on Linea.- The
explorerLinks(["Ethereum",...,"Linea",...], ...)calls properly support the "Linea" network string.
73-84: Verify Linea is supported in explorerLinks for ComposableCoW.Line 82 adds "Linea" to the explorerLinks call for ComposableCoW. Confirm that:
- Address
0xfdaFc9d1902f4e0b84f65F49f244b32b31013b74is deployed on Linea.- The "Linea" network identifier is properly registered in the
explorerLinkscomponent registry.docs/cow-protocol/tutorials/widget/widget.md (4)
89-98: LINEA additions in PartnerFee bps config look correct.Lines 89–98 properly add
[SupportedChainId.LINEA]to the per-chain bps configuration with consistent fee structure{ [TradeType.SWAP]: 100, [TradeType.LIMIT]: 50, [TradeType.ADVANCED]: 30 }. The placement afterSupportedChainId.BNBand beforeSupportedChainId.SEPOLIAis consistent with other examples.
116-116: LINEA added consistently across per-trade-type recipient configurations.Lines 116, 128, and 140 add
[SupportedChainId.LINEA]: '0x...c',[SupportedChainId.LINEA]: '0x...y', and[SupportedChainId.LINEA]: '0x...t'respectively to the SWAP, LIMIT, and ADVANCED trade type recipient mappings. The structure is consistent with other chains.Also applies to: 128-128, 140-140
163-177: Verify inline formatting changes do not alter semantics.Lines 163–177 convert the event handler's partnerFee parameter assignments to single-line format (e.g.,
{ partnerFee: { bps: 20, recipient } }on line 172). While this is stylistic, confirm:
- The logic remains identical (it does).
- This formatting is intentional and aligns with the PR's stated objectives.
274-276: Verify slippage example formatting and LINEA relevance.Lines 274–276 show slippage configuration examples. The changes here appear to be inline formatting (converting to single-line) rather than adding LINEA-specific content. Confirm this is intentional.
docs/governance/token.md (1)
23-23: Verify COW and vCOW token deployment status on Linea.Lines 23 and 41 mark both COW and vCOW tokens as "N/A" for Linea. This indicates the tokens are not yet deployed on Linea. Confirm this is accurate—if CoW or vCOW tokens have since been bridged/deployed to Linea, these entries should include the contract addresses instead.
Also applies to: 41-41
docs/cow-amm/tutorials/cow-amm-for-solvers.md (1)
44-48: Verify BCoWHelper contract deployment status on Linea.Line 48 marks the BCoWHelper contract as "N/A" for Linea. This is consistent with the partial Linea support pattern seen elsewhere (tokens not deployed, some contracts deployed but not all helpers). Confirm this status is current.
Description
Add Linea to docs
Changes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.