-
Notifications
You must be signed in to change notification settings - Fork 24
Simplify EBBO section #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the docs and the corresponding CIP included some wording which was not particularly clear to me. I removed some sentences and remarks and also fied some formatiing and typo.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughClarified and reordered EBBO reimbursement procedures, tightened timing language (72-hour processing), allowed reimbursement from rewards address if needed, and replaced forum-based escalation with a CIP-only slashing flow; removed redundant post-slash retrieval wording and small wording tweaks. Changes
Sequence Diagram(s)N/A — documentation-only changes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 LanguageTooldocs/cow-protocol/reference/core/auctions/ebbo_specifics.md[uncategorized] ~17-~17: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL) 🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md
[uncategorized] ~17-~17: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e team’s monitoring infrastructure or a third party reaching out (for example by the user t...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🪛 markdownlint-cli2 (0.18.1)
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md
22-22: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🔇 Additional comments (2)
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md (2)
17-26: Verify content clarity and completeness.The reworded reimbursement procedures section simplifies the language effectively. However, please confirm:
- Line 17: The phrase "reaching out" is now the primary verb describing how violations are reported—verify this matches the intended procedural flow from the original documentation.
- Lines 21–22: The reworded instruction now allows reimbursement "from the rewards address" as an alternative. Ensure this provides sufficient clarity and doesn't introduce ambiguity about who bears responsibility or how accountability is traced.
- Line 24: The "72 hours of this notification" timeline is clear, but confirm this aligns with the escalation timeline described in the Slashing section (line 30).
36-36: Approve content simplification.The revised paragraph on bond replenishment is clearer and better integrated. The removal of redundant post-slash behavior description and the addition of CoW DAO participation language improves the flow and reduces duplication of CIP-referenced procedures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md (1)
17-17: Consider hyphenating "third-party" for consistency with technical writing conventions.While "third party" as a noun phrase is grammatically acceptable, hyphenating it to "third-party" is increasingly standard in technical documentation for clarity and consistency. The static analysis tool flagged this pattern.
Consider applying this change if your style guide prefers hyphenation:
-The following steps are taken, in case an EBBO violation is detected, either by the core team's monitoring infrastructure or a third party reaching out (for example by the user themselves or by solvers). +The following steps are taken, in case an EBBO violation is detected, either by the core team's monitoring infrastructure or a third-party reaching out (for example by the user themselves or by solvers).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md
[uncategorized] ~17-~17: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e team’s monitoring infrastructure or a third party reaching out (for example by the user t...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🔇 Additional comments (2)
docs/cow-protocol/reference/core/auctions/ebbo_specifics.md (2)
19-26: Well-structured reordering of reimbursement procedures.The reordering improves logical flow: calculate loss → request reimbursement → enforce deadline. The markdown indentation (3 spaces) now correctly follows linting standards, addressing the previous formatting concern. The addition of the rewards address fallback option on line 22 provides useful procedural flexibility.
30-36: ** Discrepancy between AI summary and actual escalation mechanism content.**The AI summary states that the deny-listing, forum posting, and Snapshot vote flow was removed to create "a concise CIP-based slashing flow." However, line 30 in the current file still contains the complete deny-listing and forum posting procedure and is not marked as changed. Meanwhile, line 36 appears to be new content about bond replenishment.
This creates an inconsistency: either the escalation mechanism was not simplified as claimed, or the file's current state does not reflect the changes described in the summary. Please clarify whether line 30's content (deny-listing, forum post, 72-hour wait, Snapshot vote) remains intentionally or if it should have been removed/simplified.
acanidio-econ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The English could probably be improved, but I leave that to someone else. No comments on the content
This PR streamlines the EBBO section in the documentation a bit.
The docs and the corresponding CIP included some wording which was not particularly clear to me. I removed some sentences and remarks and also fied some formatiing and typo.
Most of the old formulations were part of the CIP and can be found in the link already included.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.