Skip to content

[meta.reflection.layout] change 'entity' to 'construct' #8363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[meta.reflection.layout] change 'entity' to 'construct' #8363

wants to merge 1 commit into from
+1 −1

Conversation

@jwakely
Copy link
Member

@jwakely jwakely commented Oct 24, 2025

Fixes NB US 104-165 (C++26 CD).

Fixes https://github.com/cplusplus/nbballot/issues/745

@eisenwave eisenwave added the ballot-comment Response to an NB or ISO comment on a ballot label Oct 25, 2025
@jensmaurer jensmaurer added this to the C++26 milestone Oct 25, 2025
jensmaurer
jensmaurer approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't really increase the beauty of the standard, but it's technically correct and there is no obvious alternative. Let's go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

@tkoeppe tkoeppe

Labels

ballot-comment Response to an NB or ISO comment on a ballot

Projects

None yet

Milestone

C++26

Development

Successfully merging this pull request may close these issues.

4 participants

@jwakely @jensmaurer @tkoeppe @eisenwave