Skip to content

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Fix #846

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc requested a review from henderkes August 5, 2025 13:29
Copy link
Collaborator

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortest PR ever?

@henderkes
Copy link
Collaborator

don't forget to up to 2.7.1

@crazywhalecc crazywhalecc merged commit fa10142 into main Aug 5, 2025
23 checks passed
@crazywhalecc crazywhalecc deleted the fix/spc-exe branch August 5, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows builds failing due to missing function filter_var()
2 participants