Update okd bundle to 4.19.0-okd-scos.15 #4887
Conversation
WalkthroughUpdated the Makefile to bump the default OKD_VERSION from 4.19.0-okd-scos.1 to 4.19.0-okd-scos.15. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Makefile(1 hunks)
|
|
||
| OPENSHIFT_VERSION ?= 4.19.3 | ||
| OKD_VERSION ?= 4.19.0-okd-scos.1 | ||
| OKD_VERSION ?= 4.19.0-okd-scos.15 |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
OKD_VERSION bump to 4.19.0-okd-scos.15 — LGTM; verify artifacts and references.
Change aligns with the PR objective. This value is wired into the binary via LDFLAGS (okdVersion), so the version output should reflect the bump at build time. Recommend verifying that:
- The 4.19.0-okd-scos.15 bundle is published and downloadable.
- No other scripts/targets expect an older OKD bundle/tag or hard-code OKD-specific filenames.
Run these checks from the repo root:
And optionally confirm the version exists upstream:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Locate OKD-related references in the tree (variables, filenames, comments):"
rg -n -C2 -g '!**/vendor/**' -P '\b(OKD_VERSION|okdVersion|(^|\W)okd(\W|$)|scos)\b'
echo
echo "2) Confirm LDFLAGS wiring includes okdVersion:"
rg -n -C1 -P 'okdVersion' Makefile pkg/crc/version || true
echo
echo "3) Check for any hard-coded OKD bundle names or URLs that might still point to .1:"
rg -n -C2 -P 'okd.*(bundle|url|image|tag)|4\.19\.0-okd-scos\.1' -g '!**/vendor/**'
echo
echo "4) If you have creds/network in CI, ensure the bundle fetch path resolves (dry-run if scripted):"
rg -n -C2 -P '(curl|wget).*(okd|scos)' -g '!**/vendor/**' || trueLength of output: 9350
🌐 Web query:
Is OKD 4.19.0-okd-scos.15 published (release notes or artifacts) and intended for CRC consumption?
💡 Result:
Short answer: No — I can’t find any published release notes or release-artifacts for 4.19.0-okd-scos.15, and there’s no indication that a “.15” build was promoted for CRC. The OKD release stream and blog posts show 4.19.0-okd-scos.0 and CI builds like .04, .14, .24, etc., but not a .15, and CRC’s release notes reference a different OKD build (4.19.0-okd-scos.1) as the OKD payload used by CRC. (okd.io, origin-release.ci.openshift.org, newreleases.io)
What I checked
- OKD blog / release notes and the OKD releasestreams (origin-release) show 4.19.0-okd-scos.0 and many CI increments (.04, .14, .24, …) but I did not find any 4.19.0-okd-scos.15 entry or release notes. (okd.io, origin-release.ci.openshift.org)
- CRC release/change logs (crc v2.52.0) show CRC picked up OKD 4.19.0-okd-scos.1 as the OKD payload in that CRC release — i.e., CRC uses specific OKD builds and those are documented in CRC release notes. I could not find any CRC artifact that references a .15 build. (newreleases.io)
How you can confirm locally (quick checks)
- Look for the exact releasestream tag on the origin-release site (search releasestream pages for 4.19.0-okd-scos.*). (origin-release.ci.openshift.org)
- Check CRC release notes / changelog for which OKD payload they packaged (CRC release notes show which OKD tag a CRC binary/bundle uses). (newreleases.io)
- If you want to inspect a release payload directly, you can extract tools from the release image, e.g.:
- oc adm release extract --tools quay.io/okd/scos-release:
(replace with the exact tag you find on the releasestream). The origin-release pages link the correct registry image for each published tag. (origin-release.ci.openshift.org)
- oc adm release extract --tools quay.io/okd/scos-release:
If you need it to work with CRC
- If your goal is “can I point CRC at 4.19.0-okd-scos.15?” — since I can’t find a published .15 tag, there isn’t an official crcbundle for that tag to point CRC at. Use one of the published tags (for example whatever tag CRC itself documents, or a published origin-release tag like .14 or .24) or build an OKD CRC bundle yourself (CRC docs show how to create/use a custom bundle). (newreleases.io, crc.dev)
If you’d like, I can:
- Re-check specific registries (quay.io tags for quay.io/okd/scos-release and any relevant crc/quay repos) for a .15 tag, or
- Find the exact OKD tag CRC in your CRC version is using and provide the exact crcbundle image name you can feed to crc start.
Which would you prefer?
Citations:
- 1: https://okd.io/blog?utm_source=chatgpt.com
- 2: https://origin-release.ci.openshift.org/releasestream/4-scos-next/release/4.17.0-0.okd-scos-2024-09-24-104828?utm_source=chatgpt.com
- 3: https://newreleases.io/project/github/crc-org/crc/release/v2.52.0?utm_source=chatgpt.com
- 4: https://okd.io/blog?utm_source=chatgpt.com
- 5: https://origin-release.ci.openshift.org/releasestream/4-scos-next/release/4.17.0-0.okd-scos-2024-09-24-104828?utm_source=chatgpt.com
- 6: https://newreleases.io/project/github/crc-org/crc/release/v2.52.0?utm_source=chatgpt.com
- 7: https://origin-release.ci.openshift.org/releasestream/4-scos-next/release/4.17.0-0.okd-scos-2024-09-24-104828?utm_source=chatgpt.com
- 8: https://newreleases.io/project/github/crc-org/crc/release/v2.52.0?utm_source=chatgpt.com
- 9: https://origin-release.ci.openshift.org/releasestream/4-scos-next/release/4.19.0-okd-scos.ec.4?utm_source=chatgpt.com
- 10: https://newreleases.io/project/github/crc-org/crc/release/v2.52.0?utm_source=chatgpt.com
- 11: https://crc.dev/blog/posts/2023-06-05-create-okd-bundle/?utm_source=chatgpt.com
Fix OKD_VERSION to a published release
It appears that you’ve bumped OKD_VERSION to 4.19.0-okd-scos.15, but no such release exists upstream. CRC will embed this value via LDFLAGS and then attempt to pull the corresponding OKD bundle—resulting in a broken fetch.
• Makefile (¶6) wires OKD_VERSION into the binary correctly, and your LDFLAGS include okdVersion as expected
• However, OKD release streams only publish tags like .0, .04, .14, .24, etc.—there is no .15 (checked OKD blog/releasestreams and CRC release notes)
• Without a published 4.19.0-okd-scos.15 bundle, crc start will fail to download the payload
Next steps:
- Choose an existing OKD build (for example 4.19.0-okd-scos.14 or .24) and update OKD_VERSION accordingly
- Or publish the .15 tag and its crcbundle before bumping here
Critical: ensure the OKD_VERSION you specify actually exists upstream to avoid CI and end-user failures.
🤖 Prompt for AI Agents
Makefile around line 6 sets OKD_VERSION to "4.19.0-okd-scos.15" which does not
exist upstream; replace that value with a published OKD release (e.g.
"4.19.0-okd-scos.14" or "4.19.0-okd-scos.24") or publish the missing .15 tag and
its crcbundle before referencing it, then commit the updated OKD_VERSION so the
LDFLAGS-embedded value matches an actual upstream release to avoid crc start
fetch failures.
|
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary by CodeRabbit