fix(Dockerfile): use static-debian12 nonroot image #76
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey crossplane team! I noticed that for some reason this image is using a different base image (example). |
jbw976
reviewed
Nov 15, 2025
Dockerfile
Outdated
| # Produce the Function image. We use a very lightweight 'distroless' image that | ||
| # does not include any of the build tools used in previous stages. | ||
| FROM gcr.io/distroless/base-debian12 AS image | ||
| FROM gcr.io/distroless/base-debian12:nonroot AS image |
Member
There was a problem hiding this comment.
looks like a fair bit of other functions use static-* instead. should that change be made here too?
Contributor
Author
There was a problem hiding this comment.
Yes that makes sense, I updated the image. Can you have another look, please?
Signed-off-by: Pablo Osinaga <[email protected]>
paguos
changed the title
jbw976
approved these changes
Nov 17, 2025
Member
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
awesome, thank you for making this update!
@dalton-hill-0 i'm not a maintainer on this repo, so feel free to put your final approval on too 😉
dalton-hill-0
approved these changes
Nov 17, 2025
Collaborator
dalton-hill-0
left a comment
dalton-hill-0
left a comment
There was a problem hiding this comment.
thanks for adding this 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have: