crowbar: Modify regex of group names to forbid dots (SOC-8011) #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbock
suggested changes
May 20, 2019
Contributor
nicolasbock
left a comment
nicolasbock
left a comment
There was a problem hiding this comment.
Could you link to a bug report or some output of a failure so that I can understand better how this fails if the group contains a dot? Thanks!
Contributor
Author
|
I think there is not a bug, but there is this card https://jira.suse.com/browse/SOC-8011 |
nicolasbock
suggested changes
Jul 9, 2019
Contributor
nicolasbock
left a comment
nicolasbock
left a comment
There was a problem hiding this comment.
Thanks for the link @ilausuch ! Should we mention that in the commit message as well?
ilausuch
force-pushed
the
dots_in_group_names
branch
from
858765b to
4eb8009
Compare
Contributor
Author
|
Done |
Group names cannot contain dots because it conflicts with the url route /nodes/groups/1.0/:id/:group(.:format) Now JS doesn't allow dots in the group names More info at https://jira.suse.com/browse/SOC-8011
ilausuch
force-pushed
the
dots_in_group_names
branch
from
4eb8009 to
3c9a3ce
Compare
ilausuch
changed the title
CAlmeidadeOliveira
approved these changes
Dec 3, 2019
JanZerebecki
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group names cannot contain dots because it conflicts with
the url route
/nodes/groups/1.0/:id/:group(.:format)
Now JS doesn't allow dots in the group names
More info at https://jira.suse.com/browse/SOC-8011